Fix additional codeql flagged items #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
pujal0909,
traeok,
jace-roell and
ATorrise
|
📅 Suggested merge-by date: 3/4/2025 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/cli/__tests__/daemon/__integration__/cli.zowe.daemon.integration.suite.subtest.ts
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2437 +/- ##
==========================================
+ Coverage 91.39% 91.41% +0.01%
==========================================
Files 639 639
Lines 18275 18267 -8
Branches 3919 3953 +34
==========================================
- Hits 16703 16699 -4
+ Misses 1570 1566 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
traeok
approved these changes
Feb 18, 2025
zFernand0
approved these changes
Feb 18, 2025
packages/zostso/src/IssueTso.ts
Outdated
Comment on lines
75
to
80
| if (e.message?.includes("status 404")) { | ||
| // Set useNewApi to false to handle fallback logic | ||
| useNewApi = false; | ||
| // Continue to the old API behavior | ||
| } else { | ||
| // Re-throw for other exceptions | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
can we simplify this to...
Suggested change
| if (e.message?.includes("status 404")) { | |
| // Set useNewApi to false to handle fallback logic | |
| useNewApi = false; | |
| // Continue to the old API behavior | |
| } else { | |
| // Re-throw for other exceptions | |
| throw e; | |
| } | |
| if (e.message && !e.message.includes("status 404")) throw e; |
There was a problem hiding this comment.
Please look over the change. I made a small modification to keep the logic the same.
I implemented:
if (e.message == null || !e.message.includes("status 404")) throw e;
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
traeok
approved these changes
Feb 18, 2025
t1m0thyj
approved these changes
Feb 18, 2025
awharn
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Resolves some of the remaining CodeQL flagged items.
How to Test
Review Checklist
I certify that I have:
Additional Comments