Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node/ds): Make recall/migration logic more reliable #3479

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

traeok
Copy link
Member

@traeok traeok commented Feb 24, 2025

Proposed changes

Makes recall/refresh logic more reliable by first checking for the presence of the migr property.

However, while this does not directly fix #3471, it ensures that our logic is always correct. The refresh logic is working as expected - sometimes the mainframe system does not recall the data set immediately, even if the recall API returned a successful response, but we can only update the node based off of information we receive at the time of the refresh. This varies from system to system based on configuration and the archive tool used.

Unfortunately, we cannot subscribe to events using z/OSMF REST APIs, so the user might have no other choice than to refresh the tree once they know the data set is recalled.

Release Notes

Milestone: 3.1.2

Changelog:

  • Fixed an issue where data set migration status was incorrectly handled when the migr attribute was not present in the API response.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok linked an issue Feb 24, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (53c1630) to head (c26057e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   93.49%   93.51%   +0.02%     
==========================================
  Files         120      120              
  Lines       12694    12696       +2     
  Branches     2767     2935     +168     
==========================================
+ Hits        11868    11873       +5     
+ Misses        825      822       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review February 25, 2025 20:48
Copy link

📅 Suggested merge-by date: 3/11/2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Refresh the tree when recalling a data set
1 participant