Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in parallel or only some with a filter #490

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

Levak
Copy link
Contributor

@Levak Levak commented Jun 11, 2024

I rewrote the all_tests.sh file to spread all tests among a set amount of workers so that it runs faster on machines with lots of cores. And since I was also trying to make some fixes in pycdc I needed to run only some tests of the fixtures I was touching.

make check JOBS=4 will spawn 4 workers and spread the tests among them.
make check FILTER=try will only run tests that contain try in their name.

@TiZCrocodile
Copy link
Contributor

I think its may be good to have the option to test certain tests, but I also think that after every change, all tests should be checked, because sometimes things rely on each other and you may broke other things accidentally

@Levak
Copy link
Contributor Author

Levak commented Jun 15, 2024

I think its may be good to have the option to test certain tests, but I also think that after every change, all tests should be checked, because sometimes things rely on each other and you may broke other things accidentally

Yes, I totally agree with you on "a change in the code should be tested against all tests", but from my POV, in this project, when you're trying to implement one opcode, it rarely breaks others, besides, you just want to quickly check if it works with the intended test, and then run all tests to make sure you didn't break everything.

@Levak Levak requested a review from zrax June 18, 2024 13:25
@Levak Levak force-pushed the levak/tests-parallel branch 2 times, most recently from 43227d2 to 32cad4c Compare June 19, 2024 00:14
`make check JOBS=4` will spawn 4 workers and spread the tests among them.
`make check FILTER=try` will only run tests that contain `try` in their name.
@Levak Levak force-pushed the levak/tests-parallel branch from 32cad4c to d8f955d Compare June 19, 2024 15:56
@zrax zrax merged commit b9f3d14 into zrax:master Jun 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants