Update vacuum, move OAS to vacuum

zuplo · Jan 31, 2024 · f50af7a · f50af7a
1 parent 3c6d8c6
commit f50af7a
Show file tree

Hide file tree

Showing 15 changed files with 83,028 additions and 107 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -40,7 +40,7 @@
     "typescript": "^5.2.2"
   },
   "dependencies": {
-    "@quobix/vacuum": "^0.5.0",
+    "@quobix/vacuum": "^0.8.6",
     "@rate-my-openapi/core": "*",
     "@stoplight/spectral-core": "^1.18.3",
     "@stoplight/spectral-functions": "^1.7.2",

diff --git a/packages/cli/src/handlers/generate-rating.ts b/packages/cli/src/handlers/generate-rating.ts
@@ -34,6 +34,14 @@ export async function generateRating(argv: Arguments) {
       "../",
       "rulesets/rules.vacuum.yaml",
     );
+    // TODO: Use JS functions once bugs are fixed
+    // https://github.com/daveshanley/vacuum/issues/418
+    // const rulesetFunctionsPath = join(
+    //   process.cwd(),
+    //   "../",
+    //   "../",
+    //   "rulesets/functions",
+    // );
     const openApiFile = await readFile(pathName);
     const { stdout, stderr } = await execAwait(
       `vacuum spectral-report -r ${rulesetPath} -o ${pathName}`,
@@ -50,7 +58,9 @@ export async function generateRating(argv: Arguments) {
     try {
       outputReport = JSON.parse(stdout);
     } catch (err) {
-      throw new Error(`Failed to parse vacuum output to JSON: ${err}`);
+      throw new Error(
+        `Failed to parse vacuum output to JSON: ${err}. Output: ${stdout}`,
+      );
     }
 
     // Spectral supplement