Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments so everything fits nicely #267

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Adjustments so everything fits nicely #267

merged 1 commit into from
Jul 31, 2024

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Jul 31, 2024

This PR includes the following changes:

  • Misspell of OpenAPI on the main header
  • Update the GitHub Actions code sample
  • Use the same colors for active buttons
  • Align code samples on the page boxes
  • Prevent scrolling on laptop sized screens
  • Fix mobile ordering of RatingExamples component

Before:
Screenshot 2024-07-31 at 10 03 44 AM

Now:
Screenshot 2024-07-31 at 10 03 54 AM

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rate-my-openapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 5:09pm

@lcampos lcampos requested a review from dan-lee July 31, 2024 17:09
@lcampos lcampos merged commit 8595d9e into main Jul 31, 2024
9 checks passed
@lcampos lcampos deleted the lcampos/landing-page-adjustments branch July 31, 2024 17:11
dan-lee
dan-lee reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@dan-lee dan-lee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏

Just something that came to my mind:

In another step, to save some more space, we could remove the header on top that serves no real purpose. We still could keep the logo and put it to the left or so

>

@lcampos
Copy link
Contributor Author

lcampos commented Jul 31, 2024

Great! 👏

Just something that came to my mind:

In another step, to save some more space, we could remove the header on top that serves no real purpose. We still could keep the logo and put it to the left or so

I tried my best to keep it cause I agree it serves no real purpose lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-lee dan-lee dan-lee left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcampos @dan-lee