Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo header #280

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Redo header #280

merged 3 commits into from
Feb 6, 2025

Conversation

AdrianMachado
Copy link
Contributor

@AdrianMachado AdrianMachado commented Feb 6, 2025

Redo the RMOA header to include stars + github. I also incorporated the cross-sell header from Mockbin

Screen.Recording.2025-02-05.at.4.20.36.PM.mov

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rate-my-openapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 6:29pm

@@ -0,0 +1,359 @@
class ZuploBanner extends HTMLElement {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost completely copy=pasted from mockbin. can make it an actual module later when we land on a better design

@@ -57,7 +57,7 @@ export async function postSuccessMessage({
},
{
type: "mrkdwn",
text: `*Scopre:*\n${score}`,
text: `*Score:*\n${score}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo

@@ -20,6 +20,7 @@ if (email && process.env.NODE_ENV === "production") {
distinctId: email,
properties: {
reportId,
email,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were missing this data

@AdrianMachado AdrianMachado merged commit d1e27f7 into main Feb 6, 2025
6 checks passed
@AdrianMachado AdrianMachado deleted the redoHeader branch February 6, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant