Skip to content

Wide layout #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Wide layout #665

wants to merge 9 commits into from

Conversation

mosch
Copy link
Contributor

@mosch mosch commented Feb 12, 2025

No description provided.

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zudoku-cosmo-cargo ✅ Ready (Inspect) Visit Preview Mar 27, 2025 10:19am
zudoku-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 10:19am
zudoku-www ✅ Ready (Inspect) Visit Preview Mar 27, 2025 10:19am

Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit cd2c3ed.

Command Status Duration Result
nx run-many -t build --projects=tag:example ✅ Succeeded 1m 12s View ↗
nx run-many -t lint:ci format:ci build:ci test ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-27 10:20:36 UTC

mosch and others added 6 commits March 17, 2025 10:28
# Conflicts:
#	packages/zudoku/src/lib/components/Header.tsx
#	packages/zudoku/src/lib/components/Layout.tsx
#	packages/zudoku/src/lib/components/navigation/Sidebar.tsx
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a wide layout and refactors the navigation components while updating layout configuration and related validators. Key changes include:

  • Separation of navigation components into TopNavigation and SideNavigation with updated styling and structure.
  • Layout adjustments in Layout.tsx and Header.tsx to support the new “wide” layout option.
  • Updates in configuration and context to include layout options, along with removal of the MobileTopNavigation component.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/zudoku/src/lib/components/TopNavigation.tsx Refactored navigation components and introduced SideNavigation with new markup and styling.
packages/zudoku/src/lib/components/Layout.tsx Modified layout container classes using the cn helper to support wide layout.
packages/zudoku/src/lib/components/Header.tsx Adjusted header structure to conditionally render top navigation based on layout configuration.
packages/zudoku/src/lib/plugins/markdown/MdxPage.tsx Updated container styling to align with new layout constraints.
packages/zudoku/src/lib/components/navigation/Sidebar.tsx Updated sidebar Drawer content and adjusted navigation rendering based on page layout.
packages/zudoku/src/lib/components/Main.tsx Changed drawer direction and adjusted responsive navigation styling.
packages/zudoku/src/config/validators/common.ts Added icon and layout properties in the navigation item and page schemas.
packages/zudoku/src/lib/core/ZudokuContext.ts Introduced a layout property to support “wide” or “default” layouts.
docs/zudoku.config.tsx, examples/cosmo-cargo/zudoku.config.tsx Set layout configuration to “wide” for the documentation and example projects.
packages/zudoku/src/lib/components/MobileTopNavigation.tsx Removed the mobile top navigation component to streamline navigation handling.
Comments suppressed due to low confidence (1)

packages/zudoku/src/lib/components/Header.tsx:73

  • The variable 'page' is used in the layout condition but is not defined in the Header component. Destructure 'page' from the useZudoku() hook to fix the undefined reference.
className={cn("2xl:border-x mx-auto flex relative items-center justify-between px-4 lg:px-8 h-[--top-header-height]", page?.layout === "default" && "max-w-screen-2xl")}

dan-lee added 2 commits March 27, 2025 10:56
# Conflicts:
#	packages/zudoku/src/config/validators/common.ts
#	packages/zudoku/src/lib/components/Layout.tsx
#	packages/zudoku/src/lib/components/MobileTopNavigation.tsx
#	packages/zudoku/src/lib/components/TopNavigation.tsx
#	packages/zudoku/src/lib/plugins/markdown/MdxPage.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature
Development

Successfully merging this pull request may close these issues.

3 participants