Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: meson support, bump version to v4.1.1 #547

Merged
merged 6 commits into from
Feb 16, 2025
Merged

v4: meson support, bump version to v4.1.1 #547

merged 6 commits into from
Feb 16, 2025

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Jan 9, 2025

@mochaaP mochaaP changed the title v4: meson support v4: meson support, bump version to v4.1.1 Jan 9, 2025
@mochaaP mochaaP force-pushed the mochaa/v4/bump-version branch 3 times, most recently from 4c6b939 to b1e10db Compare January 9, 2025 19:39
@mochaaP mochaaP force-pushed the mochaa/v4/bump-version branch from b1e10db to 911b4f1 Compare January 9, 2025 19:41
@mochaaP
Copy link
Contributor Author

mochaaP commented Jan 13, 2025

Zycore needs another bump, see zyantific/zycore-c#78

@athre0z athre0z mentioned this pull request Feb 9, 2025
Merged
athre0z
athre0z approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- LGTM! :)

@athre0z athre0z requested a review from flobernd February 10, 2025 13:33
flobernd
flobernd approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@mochaaP
Copy link
Contributor Author

mochaaP commented Feb 10, 2025

I'm ready to submit this to wrapdb. Just tag me when this gets merged!

@athre0z athre0z merged commit a2278f1 into zyantific:maintenance/v4 Feb 16, 2025
24 checks passed
@athre0z
Copy link
Member

athre0z commented Feb 16, 2025

Release created: https://github.com/zyantific/zydis/releases/tag/v4.1.1

@mochaaP
Copy link
Contributor Author

mochaaP commented Feb 16, 2025

submitted to wrapdb: mesonbuild/wrapdb#1927

@mochaaP
Copy link
Contributor Author

mochaaP commented Feb 18, 2025

we might need to avoid symlinking subprojects -> dependencies to fix CI on Windows:

https://github.com/mesonbuild/wrapdb/actions/runs/13380385713/job/37367793689?pr=1927

Should this be a v5 change?

mochaaP added a commit to mcha-forks/zydis that referenced this pull request Feb 18, 2025
@mochaaP
build/meson: do not symlink subprojects -> dependencies
f6265fd 
zyantific#547 (comment)
@athre0z
Copy link
Member

athre0z commented Feb 25, 2025

Ah, I was worried that would happen, though I was told that recent Windows versions supported symlinks. Appears that was wrong then? Does meson require the directory to be called subprojects? I'm assuming you are suggesting to rename dependencies -> subprojects?

@flobernd
Copy link
Member

Symlinks do work on Windows, but only if the "Developer Mode" is active or the SeCreateSymbolicLinkPrivilege has been set for the user/group.

Both conditions are most likely not set on a CI runner (however, Dev Mode should be active for 99% of the real users I assume).

@athre0z
Copy link
Member

athre0z commented Feb 25, 2025

It seems to me that this is clearly still a problem if GitHub actions CI workers on MS' own platform do not have this enabled. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athre0z athre0z athre0z approved these changes

@flobernd flobernd flobernd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochaaP @athre0z @flobernd