objects: add account/note details to ProvenTransaction #403

[hackaugusto]

add account/note details to ProvenTransaction #403

[hackaugusto]

hummmm, the CI is failing with error: cannot find macro format in this scope. Weirdly enough locally I don't get this error (although I get different ones). I have to look into what is causing the differences.

[bobbinth]

Looks good! Thank you! I left a few small comments inline.

the CI is failing with error: cannot find macro format in this scope

I think we may just need to import format macro the way we usually import vec macro in other places.

One other thought for the future: I think with this addition the client may be able to get rid of TransactionResult struct as we could use output_note_details to store note details for off-chain notes as well. Though, we'll need to be careful not to leak off-chain info when not needed (e.g., when sending a transaction to the node).

cc @igamigo.

[bobbinth]

Looks good! Thank you! I left a couple of minor comments inline. After these, we can merge.