Create Multimodel Build CI Testing Image #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
force-pushed
the
9-env-based-dockerfile
branch
from
aa68b80 to
37570f9
Compare
aidanheerdegen
approved these changes
Aug 10, 2023
aidanheerdegen
approved these changes
Aug 14, 2023
|
Feel free to resolve those conversations that are blocking the merge (once you're read them of course ;) ) |
This was referenced Aug 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussions in https://forum.access-hive.org.au/t/ci-cd-planning-discussion/1035/3 we note that a multimodel,
spack env-based Dockerfile is the way to go for future CI stuff.This will lead to a fair bit of refactoring and removal of much of the util folder.
Should close #9 !