-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AC/DC docs #153
Update AC/DC docs #153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
The reason for indicating the dual variables in bracket is because I want to (eventually) write down the dual formulations as well. |
Makes sense. Note our dual definitions are already in the |
## Mathematical Formulation | ||
|
||
The ACOPF model considered in OPFGenerator is presented below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall comment on the model: we've encountered some issues with the sign of dual variables for constraints that are written like
@constraint(model, x + y == z)
where x, y, z
are all JuMP.VariableRef
s. Namely, JuMP may end up with x + y - z == 0
or z - x - y == 0
(I assume there is some consistency in how that transformation is done, but I don't know what it is). We ended up with dual variables that were negated compared to what we expected :(
I wrote down all the constraints with variables on the left and constant terms on the right to avoid that risk.
Again, no impact on the primal, but it can change the sign of dual variables, so I'd like to have as clear conventions as possible.
Co-authored-by: Mathieu Tanneau <9593025+mtanneau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small notation change on entering/exiting arcs 🙏
Co-authored-by: Mathieu Tanneau <9593025+mtanneau@users.noreply.github.com>
Co-authored-by: Mathieu Tanneau <9593025+mtanneau@users.noreply.github.com>
There remains one thing that I feel strongly about: writing the constraints with only constant terms in the RHS. I can make the change in the same PR as when I add the dual formulations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtanneau is in charge of adding the dual stuff in a later PR
This branch continues from
mt/ac-docs
:MathJax3
(MathJax
is deprecated)definitions.tex
filedocs-main
div so the labels fitNote this version doesn't have the corresponding dual next to each constraint / in the data table.
https://ai4opt.github.io/OPFGenerator/previews/PR153/opf/acp/