Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AC/DC docs #153
Update AC/DC docs #153
Changes from 13 commits
78a3c70
65b1c00
6f22d2c
5365b4d
23f6228
88349bb
75f84a2
2ed8342
0bf7a7b
4ab9213
e8096bd
1f391dd
30b9645
b84fe64
f923454
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall comment on the model: we've encountered some issues with the sign of dual variables for constraints that are written like
where
x, y, z
are allJuMP.VariableRef
s. Namely, JuMP may end up withx + y - z == 0
orz - x - y == 0
(I assume there is some consistency in how that transformation is done, but I don't know what it is). We ended up with dual variables that were negated compared to what we expected :(I wrote down all the constraints with variables on the left and constant terms on the right to avoid that risk.
Again, no impact on the primal, but it can change the sign of dual variables, so I'd like to have as clear conventions as possible.