remove a log message when OC compilation completes for running contract #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jan 27, 2025
heifner
approved these changes
Jan 27, 2025
| @@ -115,7 +115,6 @@ struct eosvmoc_tier { | |||
| void async_compile_complete(boost::asio::io_context& ctx, const digest_type& code_id, fc::time_point queued_time) { | |||
| if (executing_code_hash.load() == code_id) { // is action still executing? | |||
| auto elapsed = fc::time_point::now() - queued_time; | |||
| ilog("EOS VM OC tier up for ${id} compile complete ${t}ms", ("id", code_id)("t", elapsed.count()/1000)); | |||
There was a problem hiding this comment.
Fine to remove it. Could have made it a tlog. It was nice when testing as I could easily see how long it took for the queued up compiles to finish.
There was a problem hiding this comment.
Totally agree it'd be useful to have some debug or trace messaging around OC compilation, its timing, etc -- #729. In this case though it's only logged when executing_code_hash.load() == code_id which tends to really limit its utility and consistency.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I start from snapshot I can sometimes see this log once or twice. imo this ends up being deceptive because it looks like OC only tiered up 1 or 2 contracts (at least based on the current wording of the message). We already have another ilog a few lines down that logs when an interruption actually occurs. So, I don't really think we need this one.