Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a log message when OC compilation completes for running contract #1127

Merged
merged 1 commit into from
Jan 27, 2025
Merged

remove a log message when OC compilation completes for running contract #1127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libraries/chain/include/eosio/chain/wasm_interface_private.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ struct eosvmoc_tier {
void async_compile_complete(boost::asio::io_context& ctx, const digest_type& code_id, fc::time_point queued_time) {
if (executing_code_hash.load() == code_id) { // is action still executing?
auto elapsed = fc::time_point::now() - queued_time;
ilog("EOS VM OC tier up for ${id} compile complete ${t}ms", ("id", code_id)("t", elapsed.count()/1000));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to remove it. Could have made it a tlog. It was nice when testing as I could easily see how long it took for the queued up compiles to finish.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree it'd be useful to have some debug or trace messaging around OC compilation, its timing, etc -- #729. In this case though it's only logged when executing_code_hash.load() == code_id which tends to really limit its utility and consistency.

auto expire_in = std::max(fc::microseconds(0), fc::milliseconds(500) - elapsed);
std::shared_ptr<boost::asio::steady_timer> timer = std::make_shared<boost::asio::steady_timer>(ctx);
timer->expires_from_now(std::chrono::microseconds(expire_in.count()));
Expand Down
Loading