Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): disable directory fsync on AIX/os400 #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThePrez
Copy link
Contributor

@ThePrez ThePrez commented Mar 7, 2023

Pretty self-explanatory change. Running this on IBM i (an AIX variant), I get:

Error: Failed to flush to storage {
  errorOnFsync: [Error: EINVAL: invalid argument, fsync] {
    errno: -22,
    code: 'EINVAL',
    syscall: 'fsync'
  },
  errorOnClose: null
}

AIX and IBM i ('os400') need the special case as Windows.

@wangshijun wangshijun changed the title Disable directory fsync on AIX/os400 fix(core): disable directory fsync on AIX/os400 Mar 7, 2023
@wangshijun
Copy link
Contributor

@ThePrez thanks for the fix, please run make bump-version in the repo root:

  • bump version to 2.1.6
  • update changelog accordingly

Then we can merge and release after ci pass

@ThePrez
Copy link
Contributor Author

ThePrez commented Jun 25, 2023

Sorry for the delay, @wangshijun, forced push with bumped version

@wangshijun
Copy link
Contributor

Screenshot 2023-06-26 at 10 59 49

@ThePrez this pr contains a lint error that needs to be fixed before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants