Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): disable directory fsync on AIX/os400 #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(core): disable directory fsync on AIX/os400 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99f392e
Disable directory fsync on AIX/os400
ThePrez Mar 7, 2023
1714d19
Merge branch 'master' into patch-1
wangshijun Jun 26, 2023
d53add1
fix lint errors
ThePrez Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.1.6 (June 25, 2023)\n
- fix: disable directory fsync on AIX and IBM i ("os400")

## 2.1.5 (February 12, 2023)

- fix: publish config
Expand Down
8 changes: 7 additions & 1 deletion packages/core/src/storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,13 @@ storage.flushToStorage = function (options, callback) {

// Windows can't fsync (FlushFileBuffers) directories. We can live with this as it cannot cause 100% dataloss
// except in the very rare event of the first time database is loaded and a crash happens
if (flags === 'r' && (process.platform === 'win32' || process.platform === 'win64')) {
if (
flags === 'r' &&
(process.platform === 'win32' ||
process.platform === 'win64' ||
process.platform === 'aix' ||
process.platform === 'os400')
) {
return callback(null);
}

Expand Down
2 changes: 1 addition & 1 deletion version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.1.5
2.1.6