Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring Stack & Default Values in Docker Compose #18

Merged
merged 11 commits into from
Feb 18, 2025

Conversation

Michael7371
Copy link

This PR adds the following:

  • Adding default values from the sample.env to use as fallback values in the docker compose files to remove the requirement of creating a .env file
  • Monitoring deployment

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me! Easy to use. I did have to create the .env file but I didn't have to modify any values. Just wanted to clarify that since your pr description makes it seem like I wouldn't have to even do that.

@Michael7371
Copy link
Author

Works well for me! Easy to use. I did have to create the .env file but I didn't have to modify any values. Just wanted to clarify that since your pr description makes it seem like I wouldn't have to even do that.

Yeah a few variables are still required (compose profiles, docker host ip) but the goal is to have enough defaults where if it is used as a submodules a copy of a .env wouldn't be required as those variables would already be set.

@Michael7371 Michael7371 merged commit f86a47b into develop Feb 18, 2025
3 checks passed
@Michael7371 Michael7371 deleted the monitoring-stack branch February 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants