Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim compatibility #7

Merged
merged 13 commits into from
Jan 21, 2025
Merged

Tim compatibility #7

merged 13 commits into from
Jan 21, 2025

Conversation

John-Wiens
Copy link

Updates the Deduplicator for compatibility with the 4.0.0 version of the ODE.

Copy link

@Michael7371 Michael7371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just a few comments on the CI

on: [pull_request, push]

jobs:
build-deduplicator:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to deduplicator-test?

uses: actions/upload-artifact@v4
with:
name: intersection-api-test-results
path: $GITHUB_WORKSPACE/jpo-deduplicator/jpo-deduplicator/target/surefire-reports

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary for the deduplicator?


- name: Clean up
run: |
rm -rf $GITHUB_WORKSPACE/jpo-deduplicator/jpo-deduplicator/target

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above

Copy link

@Michael7371 Michael7371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Michael7371 Michael7371 merged commit 6f45623 into develop Jan 21, 2025
4 checks passed
@Michael7371 Michael7371 deleted the tim-compatibility branch January 21, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants