-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tim compatibility #7
Conversation
…on-bump Updating version for kafka ui to latest release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just a few comments on the CI
.github/workflows/ci.yml
Outdated
on: [pull_request, push] | ||
|
||
jobs: | ||
build-deduplicator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to deduplicator-test
?
.github/workflows/ci.yml
Outdated
uses: actions/upload-artifact@v4 | ||
with: | ||
name: intersection-api-test-results | ||
path: $GITHUB_WORKSPACE/jpo-deduplicator/jpo-deduplicator/target/surefire-reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary for the deduplicator?
.github/workflows/ci.yml
Outdated
|
||
- name: Clean up | ||
run: | | ||
rm -rf $GITHUB_WORKSPACE/jpo-deduplicator/jpo-deduplicator/target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Updates the Deduplicator for compatibility with the 4.0.0 version of the ODE.