I2C lock #27
Merged
I2C lock #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the locking and unlocking of the I2C bus mutex to allow for the eventual implementation of multi-threading.
Certain functions in the sensor drivers that use the I2C bus do not lock it, simply because they are functions that are meant to be called in sequence or multiple times (i.e. multiple calls to read byte for extracting data). These functions are marked with
WARNINGin their docstrings so that callers are aware that they must lock the I2C bus before performing a collection of these calls. This reduces overhead.