remove google analytics #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rphovley
requested changes
Oct 6, 2024
| @@ -10,12 +9,6 @@ import { ExtensionsPage } from '../components/Extensions/ExtensionsPage' | |||
| import extensionsService from '../services/extensions.service' | |||
| import { ExtensionsLayout } from '../layouts/ExtensionsLayout' | |||
|
|
|||
| const AppRoutesPageSubscription = () => { | |||
There was a problem hiding this comment.
Looks like this is being used a few lines later on line 16
There was a problem hiding this comment.
Do I need to do anything else to approve your changes?
rphovley
previously approved these changes
Oct 6, 2024
|
Looks good with those changes |
rphovley
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request is ready
issue-123-enable-x-does-not-disable-yIntention
We are no longer using Google Analytics, and I see no reason to use it again in the future.
Review Points
Are there any other lines of code that need to be deleted?
The code follows best practices
anytype usedNotes