Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove google analytics #241

Merged
merged 5 commits into from
Oct 9, 2024
Merged

remove google analytics #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02b2c1b
remove google analytics
nathancovey Oct 6, 2024
642de28
remove other use of google analytics
nathancovey Oct 9, 2024
df977bf
merge remote-tracking branch 'upstream/main' into issue-240-remove-go…
nathancovey Oct 9, 2024
46cfa4b
put back stuff I somehow removed in the merge lol
nathancovey Oct 9, 2024
25f025b
fix lines which were removed by accident
nathancovey Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 0 additions & 151 deletions packages/app/src/hooks/useAnalytics.ts
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions packages/app/src/routes/AppRoutes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Route, Routes } from 'react-router-dom'

import { useAnalyticsPageSubscription } from '../hooks/useAnalytics'
import InstallPage from '../components/InstallPage'
import ImportLayout from '../layouts/ImportLayout'
import { ImportPage } from '../components/ImportPage'
Expand All @@ -11,17 +10,10 @@ import { ExtensionsLayout } from '../layouts/ExtensionsLayout'
import { ContributorsPage } from '../components/ContributorsPage'
import HomePage from '../components/Home/HomePage'

const AppRoutesPageSubscription = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is being used a few lines later on line 16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to do anything else to approve your changes?

useAnalyticsPageSubscription()

return <></>
}

export const AppRoutes = () => {
const extensions = extensionsService.getActiveDashboardExtensionRoutes()
return (
<>
<AppRoutesPageSubscription />
<Routes>
<Route element={<DashboardLayout />}>
<Route path="/" element={<HomePage />} />
Expand Down
Loading