Fix self link don't match warnings for authorization endpoint #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevryghem
added
bug
testathon
…ject since the returned self link doesn't encode the uri param
…lue_contribute-7.6' into w2p-109964_fix-vocabulary-options-with-url-as-stored-value_contribute-main
alexandrevryghem
added
the
port to dspace-7_x
alexandrevryghem
force-pushed
the
w2p-109964_fix-vocabulary-options-with-url-as-stored-value_contribute-main
branch
from
fa33278 to
d3e057e
Compare
tdonohue
approved these changes
May 15, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I've verified this fixes the issue.
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
alexandrevryghem
deleted the
w2p-109964_fix-vocabulary-options-with-url-as-stored-value_contribute-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
RequestParamvalues increase the number of "self link...don't match" logs #3045Description
Because in PR #2725 all
RequestParamvalues were encoded, and that the self link don't encode all the characters (for example it doesn't encode slashes and colons) it causes the frontend to think that the links are not identical. To fix this issue now the uri parameter is simply not encoded in angular so that it doesn't complain about this issues anymore, this was how it was done before PR #2725. The ideal fix would be to fix this in the backend but this might require more changes in the core of DSpace, so we should probably wait until after the 8.0 release for that in order to have enough time to test everything. This is an example of another endpoint where the same behaviour can be reproduced, so this is a general issues.Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.