Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self link don't match warnings for authorization endpoint #3046

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix self link don't match warnings for authorization endpoint #3046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0991db
Don't encode the uri parameter of /api/authz/authorizations/search/ob…
alexandrevryghem May 14, 2024
d3e057e
Merge branch 'w2p-109964_fix-vocabulary-options-with-url-as-stored-va…
alexandrevryghem May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/core/data/feature-authorization/authorization-data.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe('AuthorizationDataService', () => {
const ePersonUuid = 'fake-eperson-uuid';

function createExpected(providedObjectUrl: string, providedEPersonUuid?: string, providedFeatureId?: FeatureID): FindListOptions {
const searchParams = [new RequestParam('uri', providedObjectUrl)];
const searchParams = [new RequestParam('uri', providedObjectUrl, false)];
if (hasValue(providedFeatureId)) {
searchParams.push(new RequestParam('feature', providedFeatureId));
}
Expand Down
3 changes: 2 additions & 1 deletion src/app/core/data/feature-authorization/authorization-data.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ export class AuthorizationDataService extends BaseDataService<Authorization> imp
if (isNotEmpty(options.searchParams)) {
params = [...options.searchParams];
}
params.push(new RequestParam('uri', objectUrl));
// TODO fix encode the uri parameter in the self link in the backend and set encodeValue to true afterwards
params.push(new RequestParam('uri', objectUrl, false));
if (hasValue(featureId)) {
params.push(new RequestParam('feature', featureId));
}
Expand Down
Loading