WIP numtracker integration #828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
callumforrester
commented
Feb 19, 2025
There was a problem hiding this comment.
Demo purposes only, this shouldn't be merged
callumforrester
commented
Feb 19, 2025
There was a problem hiding this comment.
Demo purposes only, this shouldn't be merged
callumforrester
commented
Feb 19, 2025
Comment on lines
+14
to
+26
| def file_writing() -> MsgGenerator[None]: | ||
| detectors = ["d1", "d2", "d3"] | ||
| provider = get_path_provider() | ||
|
|
||
| @bpp.run_decorator() | ||
| def inner() -> MsgGenerator[None]: | ||
| yield from bps.sleep(0.1) | ||
| for detector in detectors: | ||
| path_info = provider(detector) | ||
| print(f"{detector} -> {path_info}") | ||
| yield from bps.sleep(0.1) | ||
|
|
||
| yield from inner() |
There was a problem hiding this comment.
Demo purposes only, this shouldn't be merged
callumforrester
commented
Feb 19, 2025
Comment on lines
+115
to
+124
| _hook_run_engine_and_path_provider() | ||
|
|
||
|
|
||
| # TODO: Make the path provider ourselves and inject it into dodal, leaving BL modules to define their own offline default | ||
| def _hook_run_engine_and_path_provider() -> None: | ||
| path_provider = get_path_provider() | ||
| run_engine = context().run_engine | ||
|
|
||
| if isinstance(path_provider, StartDocumentBasedPathProvider): | ||
| run_engine.subscribe(path_provider.update_run, "start") |
There was a problem hiding this comment.
This should be removed and done in a separate PR
callumforrester
commented
Feb 19, 2025
| @@ -5,10 +5,15 @@ | |||
|
|
|||
| from bluesky_stomp.messaging import StompClient | |||
| from bluesky_stomp.models import Broker, DestinationBase, MessageTopic | |||
| from dodal.common.beamlines.beamline_utils import ( | |||
| StartDocumentBasedPathProvider, | |||
There was a problem hiding this comment.
This should be removed and done in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.