NPI-3688 Improved SP3 content writer tests, test data, header formatting correctness, and comment handling / passthrough options #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne by line and display diffs of the incorrect lines
…ng at least the minimum number of comment lines are output. Also change minimal comment to fit the spec, which includes an extra space.
…t already set, as this is the version it outputs
…ines without newlines on them, but add these back in just before concatenating header output
…irst header line specification compliant. Update SP3 test data to match the SP3d spec regarding alignment of the Data Used field.
…o make things more general. Added specific wrapper function for SP3 header datetime formatting.
…ed to 6 chars as a way of adding leading whitespace, which was confusing)
treefern
changed the title
treefern
changed the title
…3 checks, to better reflect current implementation state
ronaldmaj
requested changes
Jan 31, 2025
| def remove_offline_sats(sp3_df: _pd.DataFrame, df_friendly_name: str = ""): | ||
| def reflow_string_as_lines_for_comment_block( | ||
| comment_string: str, line_length_limit: int = SP3_COMMENT_MAX_LENGTH, comment_line_lead_in: str = SP3_COMMENT_START | ||
| ) -> list[str]: |
There was a problem hiding this comment.
You will need to import List from typing (from typing import List) and use that rather than list
| return output_lines | ||
|
|
||
|
|
||
| def get_sp3_comments(sp3_df: _pd.DataFrame) -> list[str]: |
|
|
||
| def update_sp3_comments( | ||
| sp3_df: _pd.DataFrame, | ||
| comment_lines: Union[list[str], None] = None, |
| @@ -270,11 +275,71 @@ def mjd2j2000(mjd: _np.ndarray, seconds_frac: _np.ndarray, pea_partials=False) - | |||
| return datetime2j2000(datetime) | |||
|
|
|||
|
|
|||
| def j2000_to_igs_dt(j2000_secs: _np.ndarray) -> _np.ndarray: | |||
There was a problem hiding this comment.
We should probably have unittests for this and the other functions as well? (including j2000_to_igs_epoch_row_header_dt and j2000_to_sp3_head_dt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: