-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPI-3688 Improved SP3 content writer tests, test data, header formatting correctness, and comment handling / passthrough options #73
Open
treefern
wants to merge
20
commits into
main
Choose a base branch
from
NPI-3688-store-and-output-sp3-comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
de7f6a6
SP3 comment preservation and output
treefern 80c1c47
sp3 unit tests for content generation functions
treefern 642f62d
NPI-3688 improve sp3 generation function unit test to check output li…
treefern 2918387
NPI-3688 improve sp3 comment output functionality to auto-pad, ensuri…
treefern a5ca5fd
NPI-3688 update sp3 header generator to set format version to d if no…
treefern ef29722
NPI-3688 add constants for SP3 comment start sequence and max length
treefern 98e2759
NPI-3688 add checks for SP3 format version, and start of an optional …
treefern bf36200
NPI-3688 update SP3 comment handling to store and work with comment l…
treefern 8c3ba83
NPI-3688 initial attempt at fixing SP3 header line 1 alignments, need…
treefern 1a00f62
NPI-3688 Fix field size and padding in gen_sp3_header() to make the f…
treefern a5e49f5
NPI-3688 deprecated j20002rnxdt and refactored into three functions t…
treefern c3a90a1
NPI-3688 fix realignment issue in date formatting (year had been padd…
treefern d93fb07
NPI-3688 sp3 comment handling utilities
treefern 4417c4f
Complex conflict resolution - Merge branch 'main' into NPI-3688-store…
treefern b0e10db
NPI-3688 todo for better tests for comment handling functions. Lintin…
treefern eb46238
NPI-3688 add todo for attribute merge test
treefern 55b0375
NPI-3688 remove actioned todos and no longer relevant comments
treefern caac791
NPI-3688 fix SP3 comment update function to not expect optional args
treefern 6fa2f97
NPI-3688 remove todo after checking functionality
treefern d5f5441
NPI-3688 cleanup docstring and parameter name relating to stricter SP…
treefern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have unittests for this and the other functions as well? (including
j2000_to_igs_epoch_row_header_dt
andj2000_to_sp3_head_dt
)