Handle whole domain commitment by pointer #16529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
| srs.get_lagrange_basis_from_domain_size(domain_size as usize).clone().into_iter().map(|x| x.into()).collect() | ||
| // read the commitment at the pointers address, hack for the web worker implementation (see o1js web worker impl for details) | ||
| let b = unsafe { Box::from_raw(ptr) }; | ||
| b.as_ref().clone() |
There was a problem hiding this comment.
I am worried about the overhead that cloning can add.
I would try with a Result<L, E> as I think there is a pointer under the hood too.
There was a problem hiding this comment.
As discussed with @Trivo25, I would give a shot with the Result right after, maybe before a release.
dannywillems
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion
o1-labs/o1js-bindings#327
o1-labs/o1js#1984