Handle whole domain commitment by pointer #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a4f6cd.
This was referenced Jan 27, 2025
dannywillems
approved these changes
Jan 27, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| Subproject commit 36df9f04e0fd37c2178f22972a94fffc106dd78d | |||
| Subproject commit 98d8ebb109e3e25e3cfeabec0f11bdf0a202d8e3 | |||
There was a problem hiding this comment.
Suggested change
| Subproject commit 98d8ebb109e3e25e3cfeabec0f11bdf0a202d8e3 | |
| Subproject commit 98d8ebb109e3e25e3cfeabec0f11bdf0a202d8e3-dirty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, returning a UintXArray from wasm inside a worker caused the worked to idle indefinitely because it waits for a pointer to indicate when the worker finished processing a function. however, UintXArray return values were coerced into zero pointers - resulting in the worker idling forever. we now return a pointer instead of a UintXArray directly and later consuming that pointer in the main thread. see https://github.com/o1-labs/o1js-bindings/blob/46960832d283b6286c63b9784f1e34e80c28a2d1/js/web/worker-spec.js#L110
companion
o1-labs/o1js-bindings#327
MinaProtocol/mina#16529