feat: minor tweaks on verify function #21549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
benr-ml
reviewed
Mar 20, 2025
| @@ -366,7 +375,7 @@ impl CoseSign1 { | |||
| Value::Bytes(vec![]), | |||
| Value::Bytes(self.payload.as_slice().to_vec()), | |||
| ]); | |||
| let mut bytes = Vec::with_capacity(self.protected.len() + self.payload.len()); | |||
| let mut bytes = Vec::with_capacity(self.protected.len() + self.payload.len() + 17); | |||
| "timestamp not found".to_string(), | ||
| ))? | ||
| .as_integer() | ||
| .and_then(|integer| u64::try_from(integer).ok()) |
| ) | ||
| })?; | ||
|
|
||
| for i in [0, 1, 2, 3, 4, 8] { |
There was a problem hiding this comment.
should we return error if we see, e.g., pcr 5?
| } | ||
| let mut certs = Vec::with_capacity(arr.len()); | ||
| for cert in arr.iter() { | ||
| let cert_bytes = cert.as_bytes().unwrap(); |
There was a problem hiding this comment.
can we use except with a description
| .ok_or(NitroAttestationVerifyError::InvalidAttestationDoc( | ||
| "cabundle not found".to_string(), | ||
| ))? | ||
| .as_array() |
There was a problem hiding this comment.
can there be more than one cert chain?
|
|
||
| let document_map = match document_data { | ||
| ciborium::value::Value::Map(map) => map, | ||
| let document_map: HashMap<String, Value> = match document_data { |
There was a problem hiding this comment.
is there a reasonable length limit on payload we can use?
| document_map: &HashMap<String, Value>, | ||
| ) -> Result<AttestationDocument, NitroAttestationVerifyError> { | ||
| let module_id = document_map | ||
| .get("module_id") |
There was a problem hiding this comment.
just making sure it's the case - .get() is implemented as a map in O(1) query time, and not using a linear search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.