Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor tweaks on verify function #21549

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+530 −134
Open

feat: minor tweaks on verify function #21549

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ab0e2
address review comments, add more tests
joyqvq Mar 19, 2025
a1b4d78
more tests
joyqvq Mar 20, 2025
85dabbd
better error handling
joyqvq Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/sui-types/src/error.rs
View file
Original file line number Diff line number Diff line change
@@ -675,8 +675,8 @@ pub enum SuiError {
#[error("The request did not contain a certificate")]
NoCertificateProvidedError,

#[error("Enclave attestation failed: {0}")]
AttestationFailedToVerify(String),
#[error("Nitro attestation verify failed: {0}")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: In the future when we support options other than Nitro how would we differentiate errors?

NitroAttestationFailedToVerify(String),
}

#[repr(u64)]
Loading
Oops, something went wrong.
Loading
Oops, something went wrong.