Get missing values and dtype without re-opening the dataset

[davidhassell]

Description

Get missing values and dtype without re-opening the dataset

Closes #179

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

• This pull request has a descriptive title and labels
• This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
• Unit tests have been added (if codecov test fails)
• Any changed dependencies have been added or removed correctly (if need be)
• All tests pass

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b31ca82) 86.93% compared to head (53f4ed4) 87.11%.

Files	Patch %	Lines
activestorage/active.py	95.00%	2 Missing ⚠️
activestorage/netcdf_to_zarr.py	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   86.93%   87.11%   +0.17%     
==========================================
  Files           8        8              
  Lines         620      613       -7     
==========================================
- Hits          539      534       -5     
+ Misses         81       79       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valeriupredoi]

Hi @davidhassell - many thanks for this, bud! Great progress! Unfortunately it's not there just yet - a bit of a hiccup wrt S3 file reading and tests, see eg failed test suite on S3 - mostly related to the "missing/missing values" API still needing a bit of tweaking for the S3 storage type, but also (interestingly) a certain file that can not be opened now anymore. I fixed a couple POSIX tests so we can get a quote on coverage, a few statements need tests, but I can add those after you've addressed the S3-related issues. Cheers 🍺

[davidhassell]

OK - tests passing :)

[valeriupredoi]

valiant effort @davidhassell ! Let me write us a couple tests for the missing statements, then will merge 👍 🍻

[valeriupredoi]

brilliant, cheers very much @davidhassell 🍻 I'll fix the loader test in netcdf to zarr for better cov when we have the next PR ready about 👍