Upgrade genie-common-internal to spring cloud aws 3 #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhou2
commented
Feb 4, 2025
bhou2
commented
- upgrade io.awspring.cloud:spring-cloud-aws-dependencies to 3.2.1
…ependencies: 3.2.1
genie-agent-app/build.gradle
Outdated
| @@ -25,6 +25,14 @@ license { | |||
| exclude "*.txt" | |||
| } | |||
|
|
|||
| dependencyManagement { | |||
| imports { | |||
| mavenBom "com.amazonaws:aws-java-sdk-bom:1.12.99" | |||
There was a problem hiding this comment.
com.amazonaws is AWS SDK V1 and with Amazon's announcement of end-of-support for AWS SDK for Java v1.x you'll have to move to V2 eventually
(jFYI, both V1 and V2 will continue being supported with upgrade to Spring Boot for now)
genie-agent/build.gradle
Outdated
| @@ -53,7 +61,6 @@ dependencies { | |||
| *******************************/ | |||
|
|
|||
| implementation("io.grpc:grpc-netty") | |||
| implementation("io.awspring.cloud:spring-cloud-starter-aws") | |||
There was a problem hiding this comment.
you sure this is safe to drop? for reference, Spring Cloud 3 starter name is io.awspring.cloud:spring-cloud-aws-starter
genie-agent-app/build.gradle
Outdated
| dependencyManagement { | ||
| imports { | ||
| mavenBom "com.amazonaws:aws-java-sdk-bom:1.12.99" | ||
| mavenBom "io.awspring.cloud:spring-cloud-aws-dependencies:3.2.1" |
There was a problem hiding this comment.
you should also
- update Spring Boot version in https://github.com/Netflix/genie/blob/master/gradle.properties#L23-L24
- either reuse that
spring_cloud_versionvar or remove it - Spring Boot 3 integrates with flyway 10: https://github.com/Netflix/genie/blob/master/gradle.properties#L30, check if you can use Spring Boot BOM recommendation instead of hardcoded version
bhou2
force-pushed
the
upgrade-spring-cloud-aws3
branch
from
c9d6848 to
b6560c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.