Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade genie-agent and genie-web to Spring Boot 3 #1225

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ plugins {
id "com.netflix.nebula.facet" version "11.0.0" apply false
id "org.ajoberstar.grgit" version "4.1.1"
id "org.ajoberstar.git-publish" version "3.0.1"
id "org.springframework.boot" version "${spring_boot_version}" apply false
id "org.springframework.boot" version "${spring_boot_3_version}" apply false
id "org.asciidoctor.jvm.convert" version "3.3.2" apply false
id "com.gorylenko.gradle-git-properties" version "2.3.2" apply false
id "com.google.protobuf" version "0.8.18" apply false
Expand All @@ -36,6 +36,8 @@ ext.javaProjects = subprojects.findAll {
it.name != "genie-demo" && it.name != "genie-ddl" && it.name != "genie-docs"
}

def springBoot3ProjectNames = ['genie-agent', 'genie-agent-app', 'genie-app', 'genie-common-internal', 'genie-swagger', 'genie-ui', 'genie-web']

allprojects {
apply plugin: "jacoco"
apply plugin: "idea"
Expand Down Expand Up @@ -93,14 +95,31 @@ configure((Set<Project>) ext.javaProjects) {
}

dependencyManagement {
if (springBoot3ProjectNames.contains(project.name)) {
imports {
mavenBom "org.springframework.boot:spring-boot-dependencies:${spring_boot_3_version}"
mavenBom "org.springframework.cloud:spring-cloud-dependencies:${spring_cloud_3_version}"
mavenBom "io.awspring.cloud:spring-cloud-aws-dependencies:${spring_cloud_aws_3_version}"
}
dependencies {
dependency("io.awspring.cloud:spring-cloud-aws-starter:${spring_cloud_aws_3_version}")
}
} else {
imports {
mavenBom "org.springframework.boot:spring-boot-dependencies:${spring_boot_2_version}"
mavenBom "org.springframework.cloud:spring-cloud-dependencies:${spring_cloud_2_version}"
mavenBom "io.awspring.cloud:spring-cloud-aws-dependencies:${spring_cloud_aws_2_version}"
}
}

imports {
mavenBom SpringBootPlugin.BOM_COORDINATES
mavenBom "org.springframework.cloud:spring-cloud-dependencies:${spring_cloud_version}"
mavenBom "io.awspring.cloud:spring-cloud-aws-dependencies:2.4.1"
mavenBom "com.amazonaws:aws-java-sdk-bom:1.12.780"
mavenBom "software.amazon.awssdk:bom:2.30.17"
mavenBom "io.zipkin.brave:brave-bom:5.13.3"
mavenBom "com.google.protobuf:protobuf-bom:${protobuf_version}"
mavenBom "com.squareup.okhttp3:okhttp-bom:4.9.2"
mavenBom "io.grpc:grpc-bom:${grpc_version}"
mavenBom "org.spockframework:spock-bom:2.0-groovy-3.0"
mavenBom "org.spockframework:spock-bom:2.4-M5-groovy-3.0"
mavenBom "org.testcontainers:testcontainers-bom:1.16.3"
}
dependencies {
Expand Down Expand Up @@ -157,6 +176,7 @@ configure((Set<Project>) ext.javaProjects) {

configurations {
all*.exclude group: "javax.servlet", module: "servlet-api"
all*.exclude group: "org.apache.groovy" // exclude groovy@4 dependencies
all*.exclude group: "org.springframework.boot", module: "spring-boot-starter-logging"
}

Expand Down Expand Up @@ -205,7 +225,6 @@ configure((Set<Project>) ext.javaProjects) {
testCompileOnly("com.github.spotbugs:spotbugs-annotations")

testRuntimeOnly("jakarta.el:jakarta.el-api")
testRuntimeOnly("org.glassfish:jakarta.el")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine")
}

Expand Down
12 changes: 12 additions & 0 deletions dependencies.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"jacocoAgent": {
"org.jacoco:org.jacoco.agent": {
"locked": "0.8.12"
}
},
"jacocoAnt": {
"org.jacoco:org.jacoco.ant": {
"locked": "0.8.12"
}
}
}
Loading
Loading