Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.zarr: 2.18.3 -> 3.0.4 #373248

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 12, 2025

Currently draft since at least the following packages need to be updated upstream to the Zarr 3.x. API:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 13, 2025
@bcdarwin bcdarwin changed the title python312Packages.zarr: 2.18.3 -> 3.0.0 python312Packages.zarr: 2.18.3 -> 3.0.2 Feb 13, 2025
@dotlambda
Copy link
Member

  • python312Packages.multiscale-spatial-image

I can't find an upstream issue for that. Mind opening one?

@doronbehar
Copy link
Contributor

doronbehar commented Feb 24, 2025

  • python312Packages.multiscale-spatial-image

I can't find an upstream issue for that. Mind opening one?

Done, also for tifffile, and updated the top comment of the PR. Also, I pushed a few more commits related to the main topic of the PR. I also added there reproject which is another direct dependency of zarr.

@doronbehar doronbehar changed the title python312Packages.zarr: 2.18.3 -> 3.0.2 python312Packages.zarr: 2.18.3 -> 3.0.4 Feb 25, 2025
@doronbehar
Copy link
Contributor

doronbehar commented Feb 25, 2025

After working a bit with the patch here and with zarr v3 directly, I noticed that many features of it are missing in comparison to version 2.x. Even if the dependencies mentioned in the PR's top comment will adapt to v3, I think we should still have a zarr2 attribute and perform a gradual transition. Do you think @dotlambda maybe we should at the moment create a zarr3 (and zarr2) attribute(s) and later on handle the dependencies? In a similar fashion to what we did with Numpy.. It would be nice to let Nixpkgs users be able to use zarr3 if they want to without maintaining a fork. I anticipate that the dependent packages will take time to adapt anyway, also possibly due to missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants