Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page layouts #524

Open
huss opened this issue Dec 11, 2020 · 8 comments
Open

page layouts #524

huss opened this issue Dec 11, 2020 · 8 comments
Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Dec 11, 2020

As we have expanded what OED can do, we are having issues with the layout of the page. For example, the new map choice means the options often go beyond the area set aside. Maybe making this a drop-down would be the correct fix. We should make sure the docked menus do similar things. (Fixed by PR #598)

On a related item, when we change languages (see French as an example) the translated text can exceed the area reserved for the text. We should see if there is a general way to fix this.

@huss huss added this to the 1.0 Release milestone Dec 11, 2020
@huss huss modified the milestones: 1.0 Release, 0.7 release Feb 27, 2021
@huss huss added p-high-priority This issue should be the focus of design and developement effort. t-enhancement This issues tracks a potential improvement to the software labels Feb 27, 2021
@LouisLu705 LouisLu705 mentioned this issue Mar 3, 2021
5 tasks
@huss
Copy link
Member Author

huss commented Mar 6, 2021

PR #598 did the dropdown menu. The issue of it exceeding the allowed area is still there.

@huss huss modified the milestones: 0.7 release, 1.0 Release Apr 12, 2021
@huss
Copy link
Member Author

huss commented Apr 12, 2021

Pushed back to 1.0 since critical issue of map choice was fixed in PR #598.

@huss huss added p-medium-priority and removed p-high-priority This issue should be the focus of design and developement effort. labels Aug 13, 2021
@huss huss moved this to Information in UI Enhancements Oct 28, 2021
@huss huss moved this from Information to Issues in UI Enhancements Oct 28, 2021
@huss
Copy link
Member Author

huss commented Jan 20, 2022

Many of the items are scaling as expected. It appears that the ones above and below the graphic on the right side of the page do not scale correctly as show by (gotten by shrinking the horizontal size):

Screen Shot 2022-01-20 at 2 03 10 PM

where the type and language menus are above/below the the graph area. This is probably okay but would be nice to clean up and might relate to issue #466 about graphics not scaling nicely.

The click areas to choose the days for bar graphics do not wrap/scale as other items. While not related to French, it is easier to see as the name is longer (gotten by shrinking the horizontal size):

Screen Shot 2022-01-20 at 2 07 49 PM

Another little glitch was when the horizontal size was made larger it messed up by bringing the menu below up:

Screen Shot 2022-01-20 at 2 10 37 PM

This self corrected when the horizontal size was tweaked.

@huss
Copy link
Member Author

huss commented Jan 23, 2022

Another issue is on the compare graphic. The text rotated to be on the diagonal when the bar labels are longer but the one on the right can get cut off as show in this figure:

Screen Shot 2022-01-23 at 11 48 34 AM

@huss huss modified the milestones: 1.0 Release, 1.1 release Apr 22, 2023
@huss
Copy link
Member Author

huss commented Sep 8, 2023

Issue #611 is another example of this.

@huss
Copy link
Member Author

huss commented Mar 23, 2024

PR #1113 changed the page layout. Overall, some of these issues are resolved or better. However, the issue of the time selection on bar/compare/map is still there.

Ideally, a general solution to sizing would be found.

@huss
Copy link
Member Author

huss commented Mar 24, 2024

PR #1173 helps with long text that was not translated but is not a general solution.

@huss
Copy link
Member Author

huss commented Apr 3, 2024

This may need to become a separate issue but OED is not perfect with different screen sizes and then it is narrow (such as a cell phone). A general solution should be sought.

@huss huss modified the milestones: 2.0 release, 2.x Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants