Page layout update #598
Merged
Page layout update #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugh a dropdown menu so that users can choose 'line' or 'bar'... and so on.
…r being used in chartselect and are replaced by dropdown.
huss
requested changes
Mar 5, 2021
There was a problem hiding this comment.
The dropdown menu has a gray background. All other menus are white with darker text. It partly seems okay but you also have to select a meter/group to get a first graphic so the difference is not clear to me (and maybe users). Overall, I'm inclined to remove the background unless that is difficult or others think this is better.
Overall, this does what was asked and testing indicates it works fine. Note I merged in the current development so all is fine with that.
…rnationalization to dropdown text component of chart select.
huss
approved these changes
Mar 6, 2021
|
Good work and addressed everything asked. It is ready to go. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The home page now features a dropdown menu to navigate chart selection in place of the old group of buttons. By clicking 'Select a graph type' a dropdown menu will appear and users can choose to navigate to 'line', 'bar', 'compare' or 'map'.
Partly address #524
Type of change
Checklist
Limitations
The page layout will need to be updated in the future as more features are implemented into OED. We should also add a 'highlight feature' so that when users open the dropdown menu their current graph type is highlighted.