Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for previous attempt to avoid launching parallel test nodes when they aren't needed - even with a single test, if multiple languages are selected then parallel can be useful #3377

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix for previous attempt to avoid launching parallel test nodes when they aren't needed - even with a single test, if multiple languages are selected then parallel can be useful #3377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pwiz_tools/Skyline/SkylineTester/TabTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ public override bool Run()
if (GetTestList().Length > 0)
args.Append(" perftests=on"); // In case any perf tests were explicitly selected - no harm if they weren't

if (MainWindow.RunParallel.Checked && GetTestCount() > 1) // No need for parallel on a single test
if (MainWindow.RunParallel.Checked &&
GetTestCount()*cultures.Count > 1) // No need to fire up parallel nodes on a single test in single culture
{
// CONSIDER: Should we add a checkbox for this?
// args.Append(" keepworkerlogs=1"); // For debugging startup issues. Look for TestRunner-docker-worker_#-docker.log files in pwiz root
Expand Down