feat/AB#106951_EIS-user-activity-permissions

[unai-reliefapp]

Description

feat: add user read permission check for activity download and activity logs fetch

Useful links

• Link to ticket
• Link to front-end branch if any
• Please insert any useful link ( documentation you used for example )

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

• Test A
• Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

• * I have set myself as assignee of the pull request
• * My code follows the style guidelines of this project
• * Linting does not generate new warnings
• * I have performed a self-review of my own code
• * I have put the ticket for review, adding the oort-backend team to the list of reviewers
• * I have commented my code, particularly in hard-to-understand areas
• * I have put JSDoc comment in all required places
• * My changes generate no new warnings
• * I have included screenshots describing my changes if relevant
• * I have selected labels in the Pull Request, according to the changes with code brings
• I have made corresponding changes to the documentation ( if required )
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

[unai-reliefapp]

@AntoineRelief Just to check with you that im on the right path with what I currently did, as I think I never worked on the permission side of the application yet.
Is there or do you have in mind any example about how to handle specific permissions for a single application? The idea I assume is to create a filter from the Application like

Application.find(accessibleBy(ability, 'read').Application).getFilter();

And use the found ids as a match for filtering the related activityLogs(if use has not global permissions of course)

If possible let me know, thanks
KR, Unai

[AntoineRelief]

@unai-reliefapp

I don't think we should do it this way

You can check the: extendAbilityForApplications method in the back, that check permission for a single app

if you find an application id in the query, you can use it
else, you check global permissions, to know if user can or not see the logs

[unai-reliefapp]

@AntoineRelief I changed the logic based on the extendAbilityForApplications. What i dont have clear is how or where the error should be raised if no permission is suitable.
With this logic if no permission is allowed the user will always receive an empty array.

Keeping this in draft until #1164 is merged and contains the applicationId in the metadata property

KR, Unai