Skip to content

feat/AB#106951_EIS-user-activity-permissions #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

unai-reliefapp
Copy link
Contributor

@unai-reliefapp unai-reliefapp commented Dec 4, 2024

Description

feat: add permission guard for the activity-log based on can see users

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

…rd for the activity-log based on can see users
@unai-reliefapp unai-reliefapp added enhancement New feature or request changes Changes made to existing features labels Dec 4, 2024
@unai-reliefapp unai-reliefapp self-assigned this Dec 4, 2024
@unai-reliefapp unai-reliefapp marked this pull request as ready for review December 4, 2024 15:39
@unai-reliefapp unai-reliefapp marked this pull request as draft December 4, 2024 15:40
@AntoineRelief AntoineRelief deleted the feat/AB#106951_EIS-user-activity-permissions branch December 13, 2024 14:56
@AntoineRelief
Copy link
Collaborator

@unai-reliefapp I'm changing a few things & integrating directly on the main activity log branch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes Changes made to existing features enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants