[RVBC] Add new object type RVBC #677

RuixingYangSAP · 2024-12-05T14:36:18Z

No description provided.

cla-assistant · 2024-12-05T14:36:33Z

All committers have signed the CLA.

cla-assistant · 2024-12-05T14:36:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

GuilhermeSaraiva96

Thank you for your AFF! Here are my suggestions

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.json

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

RuixingYangSAP · 2024-12-09T15:52:33Z

Hi @GuilhermeSaraiva96, Thank you for taking time reviewing our AFF. I have changed the AFF according to the suggestions from the review. Could you please kindly help to have a check again? Best regards, Ray

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.json

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

RuixingYangSAP · 2024-12-11T11:07:54Z

Hi @GuilhermeSaraiva96 , I have changed the AFF and the description header in the JSON file according to our call yesterday. In addition I added the ID field which is the review booklet ID, which for the similar reason of ina1_service_id it needs to be carried all the way to be able to run RAP based EML statement to identify the correct review booklet and do the corresponding changes.
please kindly help to have another review to see if everything is ok.

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

file-formats/rvbc/README.md

schneidermic0

Thanks, @RuixingYangSAP . I think you made great improvements.

I have added some further comments/questions.

file-formats/rvbc/examples/z_aff_example_rvbc.rvbc.json

file-formats/rvbc/README.md

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

RuixingYangSAP · 2025-01-08T12:08:30Z

Hello @schneidermic0 and @GuilhermeSaraiva96 , Happy new year! thanks for the review, and I have responsed in all the conversations. Could you please kindly have another review? thanks & BR, Ray

RuixingYangSAP · 2025-01-20T14:45:18Z

Hi @schneidermic0 , changes are done as we just discussed. Could you please kindly help review again? Thx & BR, Ray

schneidermic0

Thanks for updating the file format, @RuixingYangSAP.

Looks good for me, now.

RuixingYangSAP · 2025-01-21T14:54:24Z

Hi @GuilhermeSaraiva96, the merge is currently pending on your review. could you please kindly have a look? Thx & BR, Ray

schneidermic0 · 2025-01-21T16:46:59Z

Hi @GuilhermeSaraiva96, the merge is currently pending on your review. could you please kindly have a look? Thx & BR, Ray

@GuilhermeSaraiva96 won't be available this week.

However, usually, we merge changes as soon input of the UX review is incorporated as well.

GuilhermeSaraiva96

AFF looks good to me as well!

RuixingYangSAP · 2025-01-29T14:30:45Z

Hi @schneidermic0, I have merged the 2 ina service sections into 1 according to the request from UX review( issues 92 ). additionally there is a renaming of title for the field 'application' to be consistent to our fiori app. could you pleaes kindly review and approve? BR, Ray

wurzka

Thanks for adapting the changes regarding to our UX review! I just have one proposal for the naming.

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap

file-formats/rvbc/examples/z_aff_example_rvbc.rvbc.json

RuixingYangSAP · 2025-01-31T14:15:56Z

Hi @schneidermic0 , I made a new commit & push on updating AFF and relevant objects, but the build failed with follow error: Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
details can be found in the above failed check.
can you please have a look, and guide is there anything can be done from our side?
thx & BR, Ray

…e to name type

…stants;

…eadme.md

schneidermic0 · 2025-01-31T16:54:35Z

Argh, I have used rebase. My fault...

#683 solved the build issues.

schneidermic0

Looks good to me, now.

wurzka

Thanks, looks good to me as well

huber-nicolas added the new-object This is a new object type added to AFF label Dec 6, 2024

GuilhermeSaraiva96 requested changes Dec 9, 2024

View reviewed changes

RuixingYangSAP requested a review from GuilhermeSaraiva96 December 9, 2024 15:50

GuilhermeSaraiva96 requested changes Dec 9, 2024

View reviewed changes

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap Outdated Show resolved Hide resolved

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.json Outdated Show resolved Hide resolved

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap Outdated Show resolved Hide resolved

RuixingYangSAP requested a review from GuilhermeSaraiva96 December 10, 2024 08:45

GuilhermeSaraiva96 reviewed Dec 10, 2024

View reviewed changes

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap Outdated Show resolved Hide resolved

RuixingYangSAP requested a review from GuilhermeSaraiva96 December 11, 2024 11:05

schneidermic0 requested changes Dec 12, 2024

View reviewed changes

RuixingYangSAP force-pushed the feature/rvbc branch from 7407826 to fbd17c7 Compare December 19, 2024 12:40

RuixingYangSAP requested a review from schneidermic0 December 19, 2024 13:21

schneidermic0 requested changes Dec 20, 2024

View reviewed changes

RuixingYangSAP requested a review from schneidermic0 January 8, 2025 12:08

schneidermic0 approved these changes Jan 21, 2025

View reviewed changes

schneidermic0 added the ux-review ready AFF is ready for UX review label Jan 21, 2025

GuilhermeSaraiva96 approved these changes Jan 21, 2025

View reviewed changes

RuixingYangSAP requested a review from schneidermic0 January 29, 2025 14:29

wurzka requested changes Jan 30, 2025

View reviewed changes

file-formats/rvbc/type/zif_aff_rvbc_v1.intf.abap Outdated Show resolved Hide resolved

schneidermic0 reviewed Jan 30, 2025

View reviewed changes

file-formats/rvbc/examples/z_aff_example_rvbc.rvbc.json Outdated Show resolved Hide resolved

Markus1812 mentioned this pull request Jan 31, 2025

Update actions/upload-artifact to v4 #683

Merged

Add files of RVBC

10ed6d6

RuixingYangSAP added 24 commits January 31, 2025 17:51

correct type ty_extensibility_mode

c017b01

correct other external types

63ecbea

fix external type spras

65964ca

replace spras with ty_main_language

767aebe

adapt AFF according to the review suggetions

f32df77

change predefined_ina1_service description

88c73bf

add id field; remove unnecessary annotation $required for several fields

72421e2

change the header description in the json file

7479de0

change type ty_source, ty_status, ty_consistency_status from code typ…

1c50d01

…e to name type

correct the types from text type back to code type; add necessary con…

8c336c3

…stants;

delete unnecessary type ty_booklet_id

8d36369

remove ID and type field of INA service and related types

59e7138

change back INA related fields to structure on root level

b72409d

add example

14c014e

change CRLF to LF in example json file

403ebaf

add ending LF to example json

0fcad28

delete unnecessary abaplanguageversion field

ab42949

rename field ina1_service_name; add the Link to the example file in r…

d70b348

…eadme.md

update json schema and the example

dbfd042

remove consistencyStatus

fb57a9f

merge 2 ina services into 1; rename title of field application

635df89

move position of field application

5ac1505

remove trailing space in example json file

f74d1d5

rename titles and fields in INAservice section

bdc17e5

schneidermic0 force-pushed the feature/rvbc branch from 33992af to bdc17e5 Compare January 31, 2025 16:51

schneidermic0 approved these changes Jan 31, 2025

View reviewed changes

Merge branch 'main' into feature/rvbc

460991b

wurzka approved these changes Feb 3, 2025

View reviewed changes

wurzka merged commit 2bdb14e into SAP:main Feb 5, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RVBC] Add new object type RVBC #677

[RVBC] Add new object type RVBC #677

RuixingYangSAP commented Dec 5, 2024

cla-assistant bot commented Dec 5, 2024 •

edited

Loading

cla-assistant bot commented Dec 5, 2024

GuilhermeSaraiva96 left a comment

RuixingYangSAP commented Dec 9, 2024

RuixingYangSAP commented Dec 11, 2024

schneidermic0 left a comment

RuixingYangSAP commented Jan 8, 2025

RuixingYangSAP commented Jan 20, 2025

schneidermic0 left a comment

RuixingYangSAP commented Jan 21, 2025

schneidermic0 commented Jan 21, 2025

GuilhermeSaraiva96 left a comment

RuixingYangSAP commented Jan 29, 2025 •

edited

Loading

wurzka left a comment

RuixingYangSAP commented Jan 31, 2025

schneidermic0 commented Jan 31, 2025

schneidermic0 left a comment

wurzka left a comment

[RVBC] Add new object type RVBC #677

[RVBC] Add new object type RVBC #677

Conversation

RuixingYangSAP commented Dec 5, 2024

cla-assistant bot commented Dec 5, 2024 • edited Loading

cla-assistant bot commented Dec 5, 2024

GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

RuixingYangSAP commented Dec 9, 2024

RuixingYangSAP commented Dec 11, 2024

schneidermic0 left a comment

Choose a reason for hiding this comment

RuixingYangSAP commented Jan 8, 2025

RuixingYangSAP commented Jan 20, 2025

schneidermic0 left a comment

Choose a reason for hiding this comment

RuixingYangSAP commented Jan 21, 2025

schneidermic0 commented Jan 21, 2025

GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

RuixingYangSAP commented Jan 29, 2025 • edited Loading

wurzka left a comment

Choose a reason for hiding this comment

RuixingYangSAP commented Jan 31, 2025

schneidermic0 commented Jan 31, 2025

schneidermic0 left a comment

Choose a reason for hiding this comment

wurzka left a comment

Choose a reason for hiding this comment

cla-assistant bot commented Dec 5, 2024 •

edited

Loading

RuixingYangSAP commented Jan 29, 2025 •

edited

Loading