Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/upload-artifact to v4 #683

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

Markus1812
Copy link
Member

@Markus1812 Markus1812 commented Jan 31, 2025

Starting January 30th, 2025, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact

see https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

I've updated this to v4, but do we really need to save the generated schemas in the action? The only thing this does is to save the generated schemas in the action workflow (e.g. here, scroll to the bottom).

fixes issue in #677

@schneidermic0
Copy link
Contributor

but do we really need to save the generated schemas in the action? The only thing this does is to save the generated schemas in the action workflow (e.g. here, scroll to the bottom).

I think we can have a look at this with @albertmink next week.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @Markus1812.

@schneidermic0 schneidermic0 merged commit 9c49685 into main Jan 31, 2025
10 checks passed
@schneidermic0 schneidermic0 deleted the Markus1812-patch-1 branch January 31, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants