Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5504: Prevent JS error when link is absent in vertical linked cards #1471

Merged
merged 2 commits into from
Mar 6, 2024
Merged

SHS-5504: Prevent JS error when link is absent in vertical linked cards #1471

merged 2 commits into from
Mar 6, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Prevent JS error when link is absent in vertical linked cards
  • Add prettier config to match eslint

Need Review By (Date)

03/08

Urgency

medium

Steps to Test

  1. Create a flexible page.
  2. Add two or more postcards with the "Style" field set to "Vertical Linked Card". Leave the "Link" field empty in one of them.
  3. Save the page. Confirm that there are no errors in the javascript console.
  4. Confirm that the postcards with links work as expected.

PR Checklist

@cienvaras cienvaras self-assigned this Mar 4, 2024
@cienvaras cienvaras requested a review from mariannuar March 4, 2024 17:43
@cienvaras cienvaras marked this pull request as ready for review March 4, 2024 17:43
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-45 March 4, 2024 17:43
mariannuar
mariannuar approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras Works as expected :shipit:

@cienvaras cienvaras merged commit 6fe33f7 into fk-stnfd-sprint-45 Mar 6, 2024
8 of 9 checks passed
@cienvaras cienvaras deleted the shs-5504--vertical-linked-card-manage-layout-issues branch March 6, 2024 15:38
joegl pushed a commit that referenced this pull request Mar 12, 2024
@cienvaras
Four Kitchens Release - Sprint 45 (#1470)
3d5d350 
* feat(shs-4945): remove tertiary-reversed-darken-10 from the color mapping files (#1467)
* feat(shs-4946): remove spotlight-lighten-8 from the color mapping files and update reference to spotlight (#1468)
* SHS-5498: Shortcut menu is not displaying in admin toolbar for site editors when they log in (#1465)
* feat(shs-5498): open shortcuts toolbar menu by default on user login
* feat(shs-5498): only open shortcuts if it's not already selected on login
* feat(shs-5497): respect reduced motion for nav caret animation (#1469)
* SHS-5504: Prevent JS error when link is absent in vertical linked cards (#1471)
* chore(shs-5504): add prettier config to match eslint
* SHS-5501: Add "Raised Cards" and "Uniform Height" options to Private Collection paragraph (#1466)
* feat(shs-5501): add Uniform Height and Raised Cards fields to private collection component
* feat(shs-5501): add template for private collection paragraphs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariannuar mariannuar mariannuar approved these changes

Assignees

@cienvaras cienvaras

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @mariannuar