Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5504: Prevent JS error when link is absent in vertical linked cards #1471

Merged
merged 2 commits into from
Mar 6, 2024
Merged

SHS-5504: Prevent JS error when link is absent in vertical linked cards #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2577db
fix(shs-5504): prevent error when link is absent in vertical linked c…
cienvaras Mar 4, 2024
f6e6d96
chore(shs-5504): add prettier config to match eslint
cienvaras Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docroot/themes/humsci/humsci_basic/.prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"trailingComma": "all",
"tabWidth": 2,
"semi": true,
"singleQuote": true
}
8 changes: 7 additions & 1 deletion ...oot/themes/humsci/humsci_basic/src/js/shared/vertical-linked-card/vertical-linked-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ function verticalLinkedCard() {
// Loop through each card
cards.forEach((card) => {
// Find the main link within each card
const mainLink = card.querySelector('.hb-vertical-linked-card__title__link');
const mainLink = card.querySelector(
'.hb-vertical-linked-card__title__link',
);

if (!mainLink) {
return;
}

// Add a click event listener to each card
function handleClick() {
Expand Down
Loading