SHS-5819: Remove the Row component from the platform #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5819--remove-row-component
…-5819--remove-row-component
joegl
requested changes
Oct 11, 2024
docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.install
Outdated
Show resolved
Hide resolved
docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.install
Outdated
Show resolved
Hide resolved
|
@joegl Fixes done, thanks for the feedback! It's ready for review again. |
joegl
requested changes
Oct 16, 2024
docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.install
Outdated
Show resolved
Hide resolved
|
@ahughes3 I'm ready to merge this one but noticed you hadn't approved it yet. Want to make sure you've gotten a chance to look at it 👍 |
ahughes3
approved these changes
Oct 17, 2024
|
@joegl reviewed and approved by me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
hs_rowparagraph typehs_rowmodulestylelintinhumsci_basictheme to latest version, to remove deprecation errorNOTE: There will likely be merge conflicts after merging #1625, the update hook will need to be updated.
Need Review By (Date)
10/16
Urgency
medium
Steps to Test
/admin/structure/paragraphs_type, confirm that the Row (hs_row) paragraph type is not present anymore/admin/modules, search forhs_rowand confirm that the "H&S Row Paragraph" module is disabledPR Checklist