SHS-5785: New Well Color for Collections: Cleanup #1622

codechefmarc · 2024-09-11T18:52:30Z

READY FOR REVIEW

NOTE This should be merged in AFTER PR-1602 is merged in. This PR contains commits from that PR and the only real changes are:

Summary

Removes the old Background Color field_paragraph_style field from the Collection paragraph that was replaced with the new Background Color Field field_bg_color

Need Review By (Date)

2024-09-18

Urgency

low

Steps to Test

Login to the site as an admin
Visit the Manage fields for the Collection paragraph here: /admin/structure/paragraphs_type/hs_collection/fields
Verify there is no longer a "Background Color (old)" field with machine name field_paragraph_style
Visit the Manage fields for the Private Collection paragraph here: /admin/structure/paragraphs_type/hs_priv_collection/fields
Verify there is no longer a "Background Color (old)" field with machine name field_paragraph_style

PR Checklist

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208575409612199

…date hook to migrate old bg color to new bg color field

…ig import

…o top of paragraph toolbar

…aph toolbar

…-5783--well-color-collections

* feat(shs-5784): add new well color for collections - FE * feat(shs-5784): add new well color for collections - FE * fix(shs-5784): logic * Updated dependencies * SHS-5791: Update Stanford University brand bar link (#1618) * SHS-5791: Update Stanford University brand bar link. * feat(shs-5784): improve code in module and add vireo light well color * fix(shs-5784): add import for html * HSD8-000: Fix localist_url fieldwidget discovery (#1621) HSD8-000: Fix localist_url fieldwidget discovery. --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: CircleCI <sws-developers@lists.stanford.edu> Co-authored-by: Joe Gilliland-Lloyd <6943710+joegl@users.noreply.github.com>

…d machine name

…or-cleanup

…-5785--well-color-cleanup

cienvaras

@codechefmarc Works great, thanks!

@ahughes3 Ready for you to review.

joegl

One code suggestion here.

Also, is the intention here to delete the field_paragraph_style field completely or just remove it from the two collection paragraphs? The only other paragraph I see it being used on is hs_row which is being deprecated in #1643.

I think it's safe to delete the field entirely, which would mean deleting the field storage configuration and the permissions for it.

Otherwise if you just want to remove it and focus on deleting it completely later, then we can get this merged after the suggestion is reviewed 👍

joegl · 2024-10-16T20:00:02Z

docroot/modules/humsci/hs_paragraph_types/hs_paragraph_types.install

+  FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')->delete();
+  FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')->delete();


Suggested change

FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')->delete();

FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')->delete();

if ($hs_collection_style = FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')) {

$hs_collection_style->delete();

}

if ($hs_priv_collection_style = FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')) {

$hs_priv_collection_style->delete();

}

It's pretty safe to assume these exist, but doesn't hurt to check first just in case.

codechefmarc · 2024-10-17T18:22:17Z

One code suggestion here.

Also, is the intention here to delete the field_paragraph_style field completely or just remove it from the two collection paragraphs? The only other paragraph I see it being used on is hs_row which is being deprecated in #1643.

I think it's safe to delete the field entirely, which would mean deleting the field storage configuration and the permissions for it.

Otherwise if you just want to remove it and focus on deleting it completely later, then we can get this merged after the suggestion is reviewed 👍

Yes, I believe it is going away entirely - I would say that if this PR gets merged in first, then we add the delete of the field storage to #1643 so we don't run into any problems.

joegl · 2024-10-17T20:25:30Z

One code suggestion here.
Also, is the intention here to delete the field_paragraph_style field completely or just remove it from the two collection paragraphs? The only other paragraph I see it being used on is hs_row which is being deprecated in #1643.
I think it's safe to delete the field entirely, which would mean deleting the field storage configuration and the permissions for it.
Otherwise if you just want to remove it and focus on deleting it completely later, then we can get this merged after the suggestion is reviewed 👍

Yes, I believe it is going away entirely - I would say that if this PR gets merged in first, then we add the delete of the field storage to #1643 so we don't run into any problems.

I merged #1643 before I saw this but I agree, this should be deleted entirely in a separate PR and update hook.

joegl

LGTM

Marc Berger and others added 22 commits August 14, 2024 17:00

feat(SHS-5783): Add new background color fields to collections and up…

415c9e5

…date hook to migrate old bg color to new bg color field

feat(SHS-5783): Move update hook into deploy as it happens after conf…

eb4c7ea

…ig import

refactor(SHS-5783): Move config import to install from deploy

a39ccc0

Merge branch '11.2.2-release' into SHS-5783--well-color-collections

67116e2

Merge branch '11.2.3-release' into SHS-5783--well-color-collections

efce5e7

fix(SHS-5783): Set correct bg_color_width based on old field

b404754

fix(SHS-5783): Refactor to fix linting errors on complexity

1a791ec

fix(SHS-5783): Refactor to fix linting error about complexity

8ba80c2

feat(SHS-5771): Add patch to move drag and drop from paragraph menu t…

44fc935

…o top of paragraph toolbar

feat(SHS-5771): Add config for moving drag & drop from menu to paragr…

6eb6e4a

…aph toolbar

fix(SHS-5771): Fix update hook to get config

f071a27

Merge branch '11.2.3-release' into SHS-5771--paragraphs-drag-drop

ffe321b

chore(SHS-5771): Revert composer.lock

8080288

chore(SHS-5771): Match composer.lock to 11.2.3-release version

6330426

Merge branch '11.2.4-release' into SHS-5771--paragraphs-drag-drop

a7bca44

fix(SHS-5771): Add field config for layout builder on private page

d0e18a1

Merge branch '11.2.4-release' of github.com:SU-HSDO/suhumsci into SHS…

8d4a719

…-5783--well-color-collections

Merge branch '11.2.4-release' of github.com:SU-HSDO/suhumsci into SHS…

f663cca

…-5783--well-color-collections

feat(SHS-5783): Change Color Palette Default to Default and associate…

5448b06

…d machine name

feat(SHS-5785): Remove old collection background color field

391dbec

feat(SHS-5785): Add update hook to remove field from paragraph

6e9dacc

ahughes3 temporarily deployed to Tugboat September 11, 2024 18:52 Destroyed

codechefmarc requested a review from cienvaras September 11, 2024 19:05

codechefmarc self-assigned this Sep 11, 2024

codechefmarc added the Needs review label Sep 11, 2024

codechefmarc marked this pull request as ready for review September 11, 2024 19:05

Marc Berger added 3 commits September 12, 2024 11:02

Merge branch '11.2.4-release' into SHS-5771--paragraphs-drag-drop

587a212

refactor(SHS-5771): Testing out change to config.storage.sync service

cb359ad

chore(SHS-5771): Revert change to service, does not work as part of updb

0c23295

codechefmarc mentioned this pull request Oct 8, 2024

SHS-5771: Make the Paragraph Drag and Drop option more visible to Site Editors #1610

Merged

Merge branch 'SHS-5771--paragraphs-drag-drop' into SHS-5785--well-col…

ab871a3

…or-cleanup

ahughes3 temporarily deployed to Tugboat October 8, 2024 17:40 Destroyed

Merge branch '11.3.1-release' of github.com:SU-HSDO/suhumsci into SHS…

753e977

…-5785--well-color-cleanup

ahughes3 temporarily deployed to Tugboat October 9, 2024 23:57 Destroyed

cienvaras reviewed Oct 10, 2024

View reviewed changes

cienvaras approved these changes Oct 10, 2024

View reviewed changes

cienvaras requested a review from ahughes3 October 10, 2024 00:19

cienvaras assigned ahughes3 and unassigned codechefmarc Oct 10, 2024

cienvaras mentioned this pull request Oct 14, 2024

SHS-5819: Remove the Row component from the platform #1643

Merged

ahughes3 approved these changes Oct 15, 2024

View reviewed changes

ahughes3 assigned joegl Oct 15, 2024

ahughes3 requested a review from joegl October 15, 2024 15:37

ahughes3 removed their assignment Oct 15, 2024

Base automatically changed from 11.3.1-release to develop October 16, 2024 15:43

joegl requested changes Oct 16, 2024

View reviewed changes

joegl changed the base branch from develop to 11.4.1-release October 16, 2024 20:05

Merge branch '11.4.1-release' into SHS-5785--well-color-cleanup

128ad27

feat(SHS-5785): Double check field config exists before deleting

7a492cf

ahughes3 temporarily deployed to Tugboat October 17, 2024 18:29 Destroyed

Merge branch '11.4.1-release' into SHS-5785--well-color-cleanup

a968b7c

ahughes3 temporarily deployed to Tugboat October 17, 2024 20:21 Destroyed

joegl approved these changes Oct 17, 2024

View reviewed changes

joegl merged commit 0f6d8dd into 11.4.1-release Oct 17, 2024
14 of 15 checks passed

joegl deleted the SHS-5785--well-color-cleanup branch October 17, 2024 20:28

This was referenced Oct 29, 2024

HSD8-000: Remove paragraph_style field storage config #1670

Merged

HSD8-000: Remove field_paragraph_style permissions #1677

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SHS-5785: New Well Color for Collections: Cleanup #1622

SHS-5785: New Well Color for Collections: Cleanup #1622

codechefmarc commented Sep 11, 2024 •

edited by ahughes3

Loading

cienvaras left a comment

joegl left a comment •

edited

Loading

joegl Oct 16, 2024

codechefmarc commented Oct 17, 2024

joegl commented Oct 17, 2024

joegl left a comment

		FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')->delete();
		FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')->delete();

-  FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')->delete();
-  FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')->delete();
+if ($hs_collection_style = FieldConfig::loadByName('paragraph', 'hs_collection', 'field_paragraph_style')) {
+  $hs_collection_style->delete();
+}
+if ($hs_priv_collection_style = FieldConfig::loadByName('paragraph', 'hs_priv_collection', 'field_paragraph_style')) {
+  $hs_priv_collection_style->delete();
+}

SHS-5785: New Well Color for Collections: Cleanup #1622

SHS-5785: New Well Color for Collections: Cleanup #1622

Conversation

codechefmarc commented Sep 11, 2024 • edited by ahughes3 Loading

READY FOR REVIEW

Summary

Need Review By (Date)

Urgency

Steps to Test

PR Checklist

cienvaras left a comment

Choose a reason for hiding this comment

joegl left a comment • edited Loading

Choose a reason for hiding this comment

joegl Oct 16, 2024

Choose a reason for hiding this comment

codechefmarc commented Oct 17, 2024

joegl commented Oct 17, 2024

joegl left a comment

Choose a reason for hiding this comment

codechefmarc commented Sep 11, 2024 •

edited by ahughes3

Loading

joegl left a comment •

edited

Loading