Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS 5869: Make /user/login Drupal log-in form prettier #1651

Merged
merged 2 commits into from
Oct 10, 2024
Merged

SHS 5869: Make /user/login Drupal log-in form prettier #1651

merged 2 commits into from
Oct 10, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Oct 8, 2024 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Make /user/login Drupal log-in form prettier

Need Review By (Date)

10/09

Urgency

low

Steps to Test

  1. Go to /user/login on Colorful and Traditional
  2. Confirm the Drupal Login Form looks prettier and verify the following are happening:
  • Once the accordion is opened, there's a padding of 32px and there's a border around the content
  • Items are being displayed vertically instead of horizontally
  • Space between items are 24px

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat October 8, 2024 21:18 Destroyed
@mariannuar mariannuar marked this pull request as ready for review October 8, 2024 21:22
@ahughes3 ahughes3 temporarily deployed to Tugboat October 8, 2024 21:26 Destroyed
@mariannuar mariannuar self-assigned this Oct 8, 2024
@mariannuar mariannuar requested a review from cienvaras October 8, 2024 21:33
cienvaras
cienvaras approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks great! :shipit:

@ahughes3 Ready for you.

@cienvaras cienvaras requested a review from ahughes3 October 9, 2024 21:50
@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Oct 9, 2024
@ahughes3 ahughes3 requested a review from joegl October 10, 2024 14:03
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 10, 2024
@joegl joegl merged commit 8d36aaf into 11.3.1-release Oct 10, 2024
17 checks passed
@joegl joegl deleted the shs-5869-make-drupal-user-login-form-prettier branch October 10, 2024 15:52
@ahughes3 ahughes3 mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahughes3 ahughes3 ahughes3 approved these changes

@cienvaras cienvaras cienvaras approved these changes

@joegl joegl joegl approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariannuar @ahughes3 @cienvaras @joegl