Fix traffic graph #794
Merged
Fix traffic graph #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we introduced system components (weavelet control and deployment control), the traffic graph doesn't display anything in the weaver multi dashboard. This is because when we display the graph, we look at the components of the application and then we try to match them to the traffic between them. However, the edges show traffic for components that are missing from the status (e.g., the system components). Hence, when we display the graph there is no 1:1 mapping between components and the traffic between them. This PR fixes this issue by not displaying traffic for system components (in fact the user shouldn't care about that). Maybe a better fix would be to do this in the javascript itself, but we can do that in the future if needed.
rgrandl
force-pushed
the
fix_multi_dashboard
branch
from
82bf51c to
604488a
Compare
mwhittaker
approved these changes
Aug 23, 2024
cmd/weaver/main.go
Outdated
| @@ -165,7 +165,7 @@ func run(deployer string, args []string) (int, error) { | |||
| binary := "weaver-" + deployer | |||
| if _, err := exec.LookPath(binary); err != nil { | |||
| msg := fmt.Sprintf(`"weaver %s" is not a weaver command. See "weaver --help". If you're trying to invoke a custom deployer, the %q binary was not found. You may need to install the %q binary or add it to your PATH.`, deployer, binary, binary) | |||
| return 1, fmt.Errorf(wrap(msg, 80)) | |||
| return 1, fmt.Errorf(wrap(msg, 80), "%s") | |||
There was a problem hiding this comment.
Sorry for not understanding, but what does the "%s" do?
There was a problem hiding this comment.
Good catch. Should be fmt.Errorf("%s", wrap(msg, 80)). The linter complains if we don't specify the format.
rgrandl
force-pushed
the
fix_multi_dashboard
branch
from
8ffe799 to
4215989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we introduced system components (weavelet control and deployment control), the traffic graph doesn't display anything in the weaver multi dashboard.
This is because when we display the graph, we look at the components of the application and then we try to match them to the traffic between them. However, the edges show traffic for components that are missing from the status (e.g., the system components). Hence, when we display the graph there is no 1:1 mapping between components and the traffic between them.
This PR fixes this issue by not displaying traffic for system components (in fact the user shouldn't care about that). Maybe a better fix would be to do this in the javascript itself, but we can do that in the future if needed.