Add a pull request template #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
add-pull-request-template
branch
from
9ff95fe to
150dcb7
Compare
rnestler
commented
Feb 22, 2025
| @@ -0,0 +1,3 @@ | |||
| If you're adding a new endpoint consider the following | |||
| * [ ] Note that the list is sorted alphabetically | |||
| * [ ] Verify that your endpoint is valid using <https://validator.spaceapi.io/ui> | |||
There was a problem hiding this comment.
I think a lot of people don't know about the validator and this is a good moment to make them aware of it.
There was a problem hiding this comment.
Generally a good idea, but if we want to do this as a checklist, I'd formulate it as "This is completed", e.g. The endpoint is valid according to <https://validator.spaceapi.io/ui>, The new entry is at the correct (alphabetically sorted) line.
s3lph
requested changes
Feb 22, 2025
| @@ -0,0 +1,3 @@ | |||
| If you're adding a new endpoint consider the following | |||
| * [ ] Note that the list is sorted alphabetically | |||
| * [ ] Verify that your endpoint is valid using <https://validator.spaceapi.io/ui> | |||
There was a problem hiding this comment.
Generally a good idea, but if we want to do this as a checklist, I'd formulate it as "This is completed", e.g. The endpoint is valid according to <https://validator.spaceapi.io/ui>, The new entry is at the correct (alphabetically sorted) line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.