Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a pull request template #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
If you're adding a new endpoint consider the following
* [ ] Note that the list is sorted alphabetically
* [ ] Verify that your endpoint is valid using <https://validator.spaceapi.io/ui>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of people don't know about the validator and this is a good moment to make them aware of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good idea, but if we want to do this as a checklist, I'd formulate it as "This is completed", e.g. The endpoint is valid according to <https://validator.spaceapi.io/ui>, The new entry is at the correct (alphabetically sorted) line.