Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Font responsiveness #1110

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

adiati98
Copy link
Contributor

@adiati98 adiati98 commented Jan 7, 2024

Linked Issue

Fixes #924

Description

This PR holds below changes:

  • Comment out font sizes for h2 to h5 in the styles\_base.scss to fall back to default Tailwind's settings.
  • Add className of mt-3 to space between hero image and h1 in the app\components\layouts\DefaultLayout.tsx.

Methodology

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@adiati98 adiati98 requested a review from a team as a code owner January 7, 2024 19:29
Copy link

netlify bot commented Jan 7, 2024

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit 3abaeba
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/65aac3a2c22a5c000801aa98

@adiati98 adiati98 requested a review from danieltott January 7, 2024 19:29
@adiati98
Copy link
Contributor Author

adiati98 commented Jan 7, 2024

@danieltott, sorry for taking too long on this!

In this PR, I commented out the font size for h2 to h5 to fall back to the default Tailwind's settings.
I'm not removing them just in case we want to use it in the future.
That does the trick. But let me know if you have another solution!

I also add top margin (mt-3) to the h1 to give space between the hero image and the title.


Another thing, it took me literally 15 to 25 minutes to run pnpm until I can render a page. Whenever I change the code, it will shut down, and I have to start all over again. And I got frustrated a lot. 😅
I think this is one of Windows things.

Is it possible for me to use npm or yarn? npm is actually better so far. TIA! 😊

Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @adiati98 - thanks for putting this together ❤️

I made a couple tweaks and we're good to go!

@danieltott danieltott merged commit c7e98d7 into Virtual-Coffee:main Jan 19, 2024
5 checks passed
@adiati98
Copy link
Contributor Author

This looks great @adiati98 - thanks for putting this together ❤️

I made a couple tweaks and we're good to go!

Woohoo!!!! Thank you so much, @danieltott!!! 🤩

@adiati98 adiati98 deleted the fix/font-responsiveness branch January 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Responsiveness in Smaller Screen
2 participants